Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ChibiOS: add hwdef MFE_AirSpeed_CAN #28989

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mikefenghao
Copy link
Contributor

This is the hwdef file for MFE_AirSpeed_CAN. Please help me merge. Thanks。

@Hwurzburg Hwurzburg added the WikiNeeded needs wiki update label Jan 3, 2025
@peterbarker peterbarker force-pushed the ardupilot-MFE_AirSpeed_CAN branch from aee3f6d to 1abf0da Compare January 9, 2025 21:53
@peterbarker
Copy link
Contributor

Is there some reason this hasn't been done by includeing eg. f103-periph/hwdef.inc (and the bootloader equivalent) and then adding only what needs to be added?

Copy-and-pasting entire hwdefs around like this increases maintenance load on the project and can lead to bugs. For example, several of the dfefines around serial use are changing (and have changed) in master since this copy/paste was done.

As an example of how this might be structured - AeroFox-Airspeed is doing what I describe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WikiNeeded needs wiki update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants