Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serial passthrough parity backport #28232

Open
wants to merge 2 commits into
base: Copter-4.5
Choose a base branch
from
Open

Serial passthrough parity backport #28232

wants to merge 2 commits into from
+103 −11

Conversation

brad112358
Copy link
Contributor

These are cherry picked from my local Copter-4.5 branch which I use on a daily basis and to which I had previously backported #27152 . I've also tested it again just now in this new branch by using it to flash my MatekSys mR900-22 receiver via serial passthrough.

I've not done a backport PR before, so please let me know if there is anything else I should do to help get this released for all the vehicle types.

Thanks!

@brad112358
AP_HAL: Add support for parity to Serial passthrough
4b48a5d 
Add code to reflect USB ACM parity setting to the passthrough port alongside existing support for ACM baud rate changes.  Some use cases for serial passthrough require specific parity settings.

For example, even parity is used and required by the USART protocol used in the STM32 system bootloader. This enhancement allows the use of standard flash programming tools such as STM32CubeProgrammer to flash connected STM based peripherals such as Receivers and Telemetry radios via serial passthrough.  Some examples of such peripherals include the FrSky R9 receivers as well as various other STM based LoRa modules used by the mLRS project.
@brad112358
GCS_MAVLink: Add support for parity to Serial passthrough
a79de18 
Add code to reflect USB ACM parity setting to the passthrough port alongside existing support for ACM baud rate changes.  Some use cases for serial passthrough require specific parity settings.

For example, even parity is used and required by the USART protocol used in the STM32 system bootloader. This enhancement allows the use of standard flash programming tools such as STM32CubeProgrammer to flash connected STM based peripherals such as Receivers and Telemetry radios via serial passthrough.  Some examples of such peripherals include the FrSky R9 receivers as well as various other STM based LoRa modules used by the mLRS project.
@brad112358 brad112358 mentioned this pull request Sep 25, 2024
Merged
@amilcarlucas
Copy link
Contributor 

Binary Name      Text [B]        Data [B]     BSS (B)        Total Flash Change [B] (%)      Flash Free After PR (B)
---------------  --------------  -----------  -------------  ----------------------------  -------------------------
antennatracker   380 (+0.0288%)  0 (0.0000%)  4 (+0.0015%)   380 (+0.0287%)                                   642512
arducopter       380 (+0.0214%)  0 (0.0000%)  4 (+0.0015%)   380 (+0.0214%)                                   187616
ardusub          380 (+0.0243%)  0 (0.0000%)  4 (+0.0015%)   380 (+0.0242%)                                   396876
blimp            376 (+0.0295%)  0 (0.0000%)  0 (0.0000%)    376 (+0.0295%)                                   690344
arduplane        380 (+0.0214%)  0 (0.0000%)  -4 (-0.0015%)  380 (+0.0214%)                                   189012
ardurover        380 (+0.0233%)  0 (0.0000%)  4 (+0.0015%)   380 (+0.0233%)                                   333128
arducopter-heli  380 (+0.0213%)  0 (0.0000%)  -4 (-0.0015%)  380 (+0.0213%)                                   181808

@brad112358
Copy link
Contributor Author

@rmackay9, this seems to have stalled. Is it blocked or on hold because of flash size or some other reason?

@amilcarlucas
Copy link
Contributor

@brad112358 to make sure this gets in you need to loby for it at one of the weekly developer meetings.
Sometimes, you no not need to loby, but it is safer and faster if you do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
4.5 Backports
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brad112358 @amilcarlucas