-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GCS_MAVLink: Check if set_message_interval is too fast #28144
Conversation
46bb1c9
to
4e433af
Compare
Appears to be some issue with Works OK with MAVProxy:
are equivalent. Maybe some issue with the test ... will investigate further. |
23c1909
to
686cfba
Compare
Appears to be an unrelated test failure in |
686cfba
to
a6d49b4
Compare
For the autotests, there appears to be an issue with
So it tries to set an interval of 10.100010us (which is way above the SCHED_LOOP_RATE). Best guess there's a missing Hz->usec conversion somewhere ... can't seem to find it though :( EDIT: This is why some of the copter and rover tests are failing. It's wherever |
9f0d225
to
5e0e08c
Compare
@peterbarker, I've fixed up the autotest issues. Appears to be 2x unrelated tests failing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
For the Dev Call, since I likely won't be able to attend: |
c6aa679
to
497c27c
Compare
497c27c
to
47f4f62
Compare
Merged, thanks! |
From #28101.
Ardupilot caps the maximum message rate at 80% of
SCHED_LOOP_RATE
.If a user requests a rate faster than this via
MAV_CMD_SET_MESSAGE_INTERVAL
, the command now fails and advises the user to increaseSCHED_LOOP_RATE
.This will prevent user confusion as per the linked issue.
Tested in SITL.