fix compilation with WIN32_LEAN_AND_MEAN #297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjap
force-pushed
the
fix-lean-and-mean
branch
from
5c3af35
to
c996dcf
Compare
|
I added a new standard CMake pipeline to the CI that tests multiple compilers on different systems. Could you rebase your PR and add a setting for "WIN32_LEAN_AND_MEAN"? |
mitjap
force-pushed
the
fix-lean-and-mean
branch
from
c996dcf
to
897ff38
Compare
mitjap
force-pushed
the
fix-lean-and-mean
branch
from
897ff38
to
3e866a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #296. I changed
windows.hheader forWinsock2.h. This way the library still works even when used withWIN32_LEAN_AND_MEANpreprocessor definition.I think even better solution would be to move function
gettimeofdayintime_util.cwhich is the only place where it is used. This way we can also move any required headers (eitherwindows.h,winsock.horWinsock2.h) from header file which would prevent any side effects to other libraries.apriltag/common/time_util.h
Line 41 in cc655ad