Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further DRY with xcodegen #4

Merged
merged 55 commits into from
Sep 28, 2024
Merged

Further DRY with xcodegen #4

merged 55 commits into from
Sep 28, 2024

Conversation

mokagio
Copy link
Collaborator

@mokagio mokagio commented Sep 27, 2024

Builds on top of the xcodegen setup from #3 by:

  • Sharing sources that do not change from one chapter to the next
  • Code generating Info.plist
  • Removing the unused Assets and Preview folders from the repo
  • DRY the Makefile tasks

Via:

  find . -type d -name "Preview Content" -exec rm -rf "{}" \;
Verified via:
        diff -qr --exclude="DerivedData" --exclude="*.xcodeproj" --exclude="*.swp" --exclude=".DS_Store"
The change was done via

    find . -name "project.yml" -exec sed -i '' '/scheme:/i\
        info:\
          path: Albertos/Info.plist\
          properties:\
            UILaunchScreen:\
              UIRequiredDeviceCapabilities: [armv7]\
    ' {} +
It looked like it failed when I first tried it, but when I went back to
look at the checks as displayed in the commits list for #4, various were
green...
Via

  for d in $(find . ! -path "*/DerivedData/*" ! -path "*/.build/*" -type d -name '*.xcodeproj'); do g rm -r --cached $d; done
@mokagio mokagio merged commit 744697a into next Sep 28, 2024
15 checks passed
@mokagio mokagio deleted the more-xcodegen branch September 28, 2024 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant