Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support editing path name on mobile #6798

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Nov 15, 2024

Feature Preview

  • support editing path name for published page on mobile
  • tests
showcase.mp4

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented Nov 15, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 27 warning contribute (via Fink 🐦)

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.10%. Comparing base (7ecf213) to head (3973d05).
Report is 253 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6798      +/-   ##
==========================================
- Coverage   74.41%   65.10%   -9.31%     
==========================================
  Files         245      273      +28     
  Lines        6566    10572    +4006     
  Branches     1057     1413     +356     
==========================================
+ Hits         4886     6883    +1997     
- Misses       1628     3517    +1889     
- Partials       52      172     +120     
Flag Coverage Δ
appflowy_web_app 65.10% <ø> (-9.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 force-pushed the support_editing_path_name_on_mobile branch from d901f65 to 3973d05 Compare November 15, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant