Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add toggle heading in plus menu on mobile #6784

Merged
merged 7 commits into from
Nov 14, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented Nov 14, 2024

Feature Preview

  • add toogle headings in plus menu
  • click the expand icon should not cancel the selection
  • tests

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.09%. Comparing base (7ecf213) to head (8e4a9bf).
Report is 243 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6784      +/-   ##
==========================================
- Coverage   74.41%   65.09%   -9.32%     
==========================================
  Files         245      273      +28     
  Lines        6566    10572    +4006     
  Branches     1057     1413     +356     
==========================================
+ Hits         4886     6882    +1996     
- Misses       1628     3517    +1889     
- Partials       52      173     +121     
Flag Coverage Δ
appflowy_web_app 65.09% <ø> (-9.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LucasXu0 LucasXu0 merged commit 555d08e into AppFlowy-IO:main Nov 14, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant