Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AI chat UI improvements #6760

Merged

Conversation

richardshiue
Copy link
Collaborator

@richardshiue richardshiue commented Nov 11, 2024

please don't merge before launch review is passed.

launch review fixes (all visual, no tests required):

  • too little padding between messages from the same user (changed to 8px between message)
  • too little padding when the window is constrained on desktop (changed to 32px on either side)
  • no margins for related questions on mobile (now use 16px on either side)
  • no text overflow for related questions
  • text misalignment in sources found segment (use 12px font size as per figma)
  • user message bubble too narrow (now use 1:5 flex)
  • additional padding at beginning of mobile input text field (6px)
welcome.mp4

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented Nov 11, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 219 warning contribute (via Fink 🐦)
Message without source 3 warning contribute (via Fink 🐦)

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.11%. Comparing base (7ecf213) to head (2a5605e).
Report is 250 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6760      +/-   ##
==========================================
- Coverage   74.41%   65.11%   -9.30%     
==========================================
  Files         245      273      +28     
  Lines        6566    10572    +4006     
  Branches     1057     1413     +356     
==========================================
+ Hits         4886     6884    +1998     
- Misses       1628     3517    +1889     
- Partials       52      171     +119     
Flag Coverage Δ
appflowy_web_app 65.11% <ø> (-9.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@richardshiue richardshiue force-pushed the feat/desktop-ai-chat-improvements branch from e4ff664 to 063153c Compare November 14, 2024 13:57
@richardshiue richardshiue force-pushed the feat/desktop-ai-chat-improvements branch from 063153c to 2a5605e Compare November 14, 2024 14:33
@richardshiue richardshiue merged commit bced932 into AppFlowy-IO:main Nov 14, 2024
25 of 27 checks passed
@richardshiue richardshiue deleted the feat/desktop-ai-chat-improvements branch November 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant