Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support toggle heading #6712

Merged
merged 2 commits into from
Nov 5, 2024
Merged

feat: support toggle heading #6712

merged 2 commits into from
Nov 5, 2024

Conversation

qinluhe
Copy link
Collaborator

@qinluhe qinluhe commented Nov 4, 2024

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 58.97436% with 48 lines in your changes missing coverage. Please review.

Project coverage is 65.09%. Comparing base (7ecf213) to head (f7eb8b2).
Report is 219 commits behind head on main.

Files with missing lines Patch % Lines
...p/src/application/slate-yjs/utils/yjsOperations.ts 33.87% 39 Missing and 2 partials ⚠️
..._app/src/application/slate-yjs/utils/applyToYjs.ts 42.85% 4 Missing ⚠️
...web_app/src/application/slate-yjs/command/index.ts 0.00% 1 Missing ⚠️
...ditor/components/blocks/toggle-list/ToggleList.tsx 90.90% 0 Missing and 1 partial ⚠️
...wy_web_app/src/components/editor/utils/markdown.ts 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6712      +/-   ##
==========================================
- Coverage   74.41%   65.09%   -9.32%     
==========================================
  Files         245      273      +28     
  Lines        6566    10572    +4006     
  Branches     1057     1446     +389     
==========================================
+ Hits         4886     6882    +1996     
- Misses       1628     3517    +1889     
- Partials       52      173     +121     
Flag Coverage Δ
appflowy_web_app 65.09% <58.97%> (-9.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qinluhe qinluhe force-pushed the feat/support-document-editing branch from a4f53fe to 576ff9d Compare November 4, 2024 10:12
@qinluhe qinluhe force-pushed the feat/support-document-editing branch from 576ff9d to 10d2ef8 Compare November 4, 2024 10:17
@qinluhe qinluhe force-pushed the feat/support-document-editing branch from 7dd80a4 to f7eb8b2 Compare November 5, 2024 05:35
@qinluhe qinluhe merged commit f6e002e into main Nov 5, 2024
7 of 10 checks passed
@qinluhe qinluhe deleted the feat/support-document-editing branch November 5, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant