Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove upper pin on vyper dependency #115

Closed
wants to merge 1 commit into from

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Jun 13, 2024

What I did

trying to assist in envs where vyper is installed in 0.4

fixes: #114
fixes APE-1762

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@antazoey antazoey requested a review from mikeshultz June 13, 2024 15:53
@antazoey
Copy link
Member Author

After some discussion, going to look into actually ensuring we can flatten on 0.4...

  • update with response or increased support

@mikeshultz
Copy link
Contributor

After some discussion, going to look into actually ensuring we can flatten on 0.4...

I haven't looked at the vyper changelog or anything, but my primary concern is vyper modules. Right now imports are just treated as interfaces and transpiled accordingly. Which is probably not what we want for modules. But most of what I'm saying is guesswork. Needs investigation.

setup.py Show resolved Hide resolved
@antazoey
Copy link
Member Author

closing in favor of #118

@antazoey antazoey closed this Jun 21, 2024
@antazoey antazoey deleted the chore/vyper-vers branch July 1, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative to vyper install as a library
2 participants