Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0 -> main] SHiP: Fixes: Stack overflow, invalid index, split file access #1802

Merged
merged 14 commits into from
Oct 20, 2023
Merged

[5.0 -> main] SHiP: Fixes: Stack overflow, invalid index, split file access #1802

merged 14 commits into from
Oct 20, 2023

Conversation

heifner
Copy link
Member

@heifner heifner commented Oct 19, 2023

Includes three SHiP state_history_plugin fixes:

  • Fix for stack overflow due to recursive call to send(). Fixed by posting to the SHiP thread on new send()s.
  • Fix for accessing wrong data after log splitting.
  • Fix for accessing wrong file after log splitting.

Merges release/5.0 into main including #1779 & #1801 & #1798

Resolves #1677

heifner added 14 commits October 13, 2023 15:23
@heifner
GH-1677 Avoid stack overflow by posting to ship io_context on recursi…
fa5ff2f 
…ve send()
@heifner
GH-1677 Update index_begin_block on log split otherwise next lookup i…
1705e35 
…n index is at the wrong offset
@heifner
GH-1677 Close files as rename/swap was not working
5723fa9
@heifner
GH-1677 Add assert and error message
b795fee
@heifner
GH-1677 Add additional tests
f5b5e64
@heifner
GH-1677 Simplify split_log function as the protection against out of …
a396da9 
…file descriptors seems like overkill and is difficult to follow/verify is correct.
@heifner
GH-1677 Use EOS_ASSERT instead of elog/assert
1cb6a9d
@heifner
Merge pull request #1779 from AntelopeIO/GH-1677-ship-4.0
39327d8 
[4.0] SHiP: Fixes: Stack overflow, invalid index, split file access
@heifner
Merge remote-tracking branch 'origin/release/4.0' into GH-1677-ship-5.0
c03809e
@heifner
GH-1677 Make sure we append to index file
aee1c1d
@heifner
Merge pull request #1801 from AntelopeIO/GH-1677-ship-fix-4.0
dd4217f 
[4.0] SHiP: Make sure we append to index file
@heifner
Merge remote-tracking branch 'origin/release/4.0' into GH-1677-ship-5.0
c88a3d5
@heifner
Merge pull request #1798 from AntelopeIO/GH-1677-ship-5.0
944226b 
[4.0 -> 5.0] SHiP: Fixes: Stack overflow, invalid index, split file access
@heifner
Merge remote-tracking branch 'origin/release/5.0' into GH-1677-ship-main
8281aa3
@heifner heifner requested review from greg7mdp and linh2931 October 19, 2023 21:01
@heifner heifner added the OCI Work exclusive to OCI team label Oct 19, 2023
@heifner heifner merged commit d7caa21 into main Oct 20, 2023
21 checks passed
@heifner heifner deleted the GH-1677-ship-main branch October 20, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@linh2931 linh2931 linh2931 approved these changes

@greg7mdp greg7mdp greg7mdp approved these changes

Assignees
No one assigned
Labels
OCI Work exclusive to OCI team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Leap 4.0.4 - Exception in SHiP thread pool
3 participants
@heifner @greg7mdp @linh2931