Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADDED Favicon #59

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

saismrutiranjan18
Copy link

@saismrutiranjan18 saismrutiranjan18 commented Jan 5, 2025

#54

image

Updated Favicon. I request you to assign labels before merging the PR into the main branch.

Copy link

vercel bot commented Jan 5, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
matrubodhah ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 3:53pm

Copy link

netlify bot commented Jan 5, 2025

Deploy Preview for matrubodhah ready!

Name Link
🔨 Latest commit beec69b
🔍 Latest deploy log https://app.netlify.com/sites/matrubodhah/deploys/677e9f85d05c3100085cb64f
😎 Deploy Preview https://deploy-preview-59--matrubodhah.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Anjaliavv51
Copy link
Owner

@saismrutiranjan18 in the same way check to all , HTML pages.

@saismrutiranjan18
Copy link
Author

saismrutiranjan18 commented Jan 6, 2025

@saismrutiranjan18 in the same way check to all , HTML pages.

I Checked, it is in all pages. @Anjaliavv51 I request you to assign labels before merging the PR into the main branch.

@saismrutiranjan18
Copy link
Author

saismrutiranjan18 commented Jan 7, 2025

@saismrutiranjan18 in the same way check to all , HTML pages.

In this PR, There are 5 PR's are there from my issue's :-

  1. ADDED FAVICON - Issue no. ADD FAVICON #55 This issue is being closed but the PR isn't merged yet.
  2. Contact Button isn't working - Issue no. Contact Button isn't working #14
  3. Add Footer to Login Page - Issue no. ADD Footer Login Page #54
  4. Logo Redirectin - Logo Redirection #56
  5. Navbar Redirection Failed - Navbar Redirection Failed #58

Please Merge all these PR'S and give the labels before merging the PR, and I request you to give a suitable PR for all 5 PR's. @Anjaliavv51

@Anjaliavv51
Copy link
Owner

@saismrutiranjan18 if u make one PR for all the issues.

i can reward u max of 30points which is advanced , if u create a separate branch for each issue , u get points accordingly

@saismrutiranjan18
Copy link
Author

@saismrutiranjan18 if u make one PR for all the issues.

i can reward u max of 30points which is advanced , if u create a separate branch for each issue , u get points accordingly

Ok, I'll do this @Anjaliavv51

@iitzIrFan iitzIrFan requested a review from Anjaliavv51 January 7, 2025 06:09
@saismrutiranjan18
Copy link
Author

@saismrutiranjan18 if u make one PR for all the issues.

i can reward u max of 30points which is advanced , if u create a separate branch for each issue , u get points accordingly

Listen @Anjaliavv51 for now you can give advanced because i am not able to solve for now

@Anjaliavv51
Copy link
Owner

@saismrutiranjan18 resolve the merge conflicts

Copy link
Owner

@Anjaliavv51 Anjaliavv51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saismrutiranjan18 resolve conflicts. , so that i could merge the PR

@Anjaliavv51
Copy link
Owner

image

footer is not aligned properly @saismrutiranjan18

@Anjaliavv51
Copy link
Owner

@saismrutiranjan18 complete as soon as possible , so i can merge the PR @iitzIrFan check this PR deployment in Login page if the footer is aligned properly , attach tags and mention me attach ADVANCED and SWOC and assign this PR to him

@saismrutiranjan18
Copy link
Author

image

footer is not aligned properly @saismrutiranjan18

Actually I aligned properly, but due to conflict, it doesn't align@Anjaliavv51

@iitzIrFan
Copy link
Collaborator

@saismrutiranjan18 resolve merge conflict first as it cannot be merged this way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants