Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save the last search term and added a button to clear text #2004

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

agrogers
Copy link
Contributor

  • The previous search text is now saved
  • Button added to clear that text if when you don't want it

image

@agrogers agrogers added the 4.0 label Dec 27, 2021
This was referenced Dec 31, 2021
@tuomas2 tuomas2 added 4.1 and removed 4.0 labels Jan 13, 2022
@tuomas2
Copy link
Contributor

tuomas2 commented Jan 13, 2022

Contains new strings, so 4.1

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 13, 2022

Bug:

  1. Open Find
  2. Write "Jesus"
  3. Enable "Remember search text"
  4. Click "Find"
  5. Click back btn
    -> "Remeber search text" is disabled
    (should be enabled)

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 13, 2022

I think this would be better: #186 (comment)
What do you think about implementing that instead?

@agrogers
Copy link
Contributor Author

agrogers commented Jan 13, 2022 via email

@tuomas2
Copy link
Contributor

tuomas2 commented Jan 19, 2022

What control would you use for the drop down list?

I have used AutoCompleteTextView in document selection (see document_selection.xml). I think it would work here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for others
Development

Successfully merging this pull request may close these issues.

2 participants