Implement space toggles speak (#2622)

AndBible · Oct 12, 2023 · a7567f5 · a7567f5
1 parent 5ce5856
commit a7567f5
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/app/bibleview-js/src/composables/keyboard.ts b/app/bibleview-js/src/composables/keyboard.ts
@@ -22,7 +22,7 @@ import {computed, ComputedRef, ref, watch} from "vue";
 
 const altKeys: Set<string> = new Set(["ArrowUp", "ArrowDown", "ArrowLeft", "ArrowRight", "KeyW", "KeyM", "KeyO", "KeyG"]);
 const ctrlKeys: Set<string> = new Set(["KeyC"]);
-const keys: Set<string> = new Set(["ArrowUp", "ArrowDown"]);
+const keys: Set<string> = new Set(["ArrowUp", "ArrowDown", "Space"]);
 const handleJsSide: Set<string> = new Set(["ArrowUp", "ArrowDown"]);
 
 export function useKeyboard(
@@ -54,6 +54,7 @@ export function useKeyboard(
                     doScrolling(window.scrollY - lineHeight.value, 50);
                 }
             } else {
+                if(key === "Space" && isEditing.value) return;
                 onKeyDown(key);
             }
             e.preventDefault();

diff --git a/app/src/main/java/net/bible/android/view/activity/page/BibleJavascriptInterface.kt b/app/src/main/java/net/bible/android/view/activity/page/BibleJavascriptInterface.kt
@@ -606,6 +606,11 @@ class BibleJavascriptInterface(
                 "AltKeyO" -> mainBibleActivity.showOptionsMenu()
                 "AltKeyG" -> bibleView.window.pageManager.currentPage.startKeyChooser(mainBibleActivity)
                 "CtrlKeyC" -> bibleView.copySelectionToClipboard()
+                "Space" -> {
+                    if(!mainBibleActivity.speakControl.isStopped) {
+                        mainBibleActivity.speakControl.toggleSpeak(true)
+                    }
+                }
             }
         }
     }