Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

design-system 0.13.1 #63

Merged
merged 5 commits into from
Dec 23, 2024
Merged

design-system 0.13.1 #63

merged 5 commits into from
Dec 23, 2024

Conversation

thomasm0
Copy link
Collaborator

@thomasm0 thomasm0 commented Nov 25, 2024

Fix for various prop changes in design-system. Includes a fix too for the dark mode breaking, it was that .ams-screen sets a background-color now, so for dark mode I made this transparent.

Copy link
Collaborator

@SireeKoolenWijkstra SireeKoolenWijkstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only in dark mode. Just clicking anywhere gives me this error message:

Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

@thomasm0 thomasm0 force-pushed the chore/design-system-0.13.1 branch from 9fd41d6 to 48dcb78 Compare December 18, 2024 17:45
@thomasm0 thomasm0 marked this pull request as ready for review December 18, 2024 18:09
@thomasm0 thomasm0 requested a review from a team as a code owner December 18, 2024 18:09
@thomasm0 thomasm0 changed the title visuallyhidden replaced and breadcrumb component naming fix design-system 0.13.1 Dec 18, 2024
Copy link
Collaborator

@SireeKoolenWijkstra SireeKoolenWijkstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, all tests run!

@thomasm0 thomasm0 merged commit 5e082c2 into develop Dec 23, 2024
4 checks passed
@thomasm0 thomasm0 deleted the chore/design-system-0.13.1 branch December 23, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants