Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async support for mad-migration #72

Merged
merged 4 commits into from
Jan 7, 2021
Merged

async support for mad-migration #72

merged 4 commits into from
Jan 7, 2021

Conversation

maestro-1
Copy link
Contributor

@maestro-1 maestro-1 commented Jan 6, 2021

This was rather tricky and I had to result to using gino because sqlalchemy 1.4 breaks the utility functions.
The driver itself is ready and works exactly the same as the non-async does.

This was tested majorly with asyncpg, but I am fairly certain it would also work for aiomysql and similar async drivers

source1 = AsyncSourceDB("postgresql+asyncpg://postgres:hi12@localhost/test_db")
destination = AsyncDestinationDB("postgresql+asyncpg://postgres:hi12@localhost/tested_db")

This also comes with the very basics for async database operations even though for the time being only create_table is present.
The reason being that was a bug or perhaps a missing feature(fairly certain it is a bug) which I discovered in gino and I have raised an issue. I might raise a PR later if I get some time on my hands that way I can fix that and finish this.

@Turall Turall self-assigned this Jan 7, 2021
@Turall Turall added the enhancement New feature or request label Jan 7, 2021
@Turall Turall linked an issue Jan 7, 2021 that may be closed by this pull request
@Turall Turall merged commit c466665 into AliyevH:master Jan 7, 2021
@Turall
Copy link
Collaborator

Turall commented Jan 7, 2021

Hi @maestro-1
Good job. We are waiting for further improvements from you.

@Turall
Copy link
Collaborator

Turall commented Jan 7, 2021

@maestro-1 can you provide information on this in the readme file?

@maestro-1
Copy link
Contributor Author

@maestro-1 can you provide information on this in the readme file?

I can and I intend to. However, at this time there really is nothing to add to the readme file, at least non that I can think of.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

async driver support for migration data and create schemas
2 participants