Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(patch): upgrade patch module #7738

Merged
merged 4 commits into from
Dec 30, 2024
Merged

Conversation

KirCute
Copy link
Contributor

@KirCute KirCute commented Dec 28, 2024

Add upgrade patch module, which allows for the execution of a function during the first startup after a user upgrades from an older version.
Add a patch from v3.41.0: if admin does not have Permission 0(can see hidden) - 9(webdav manage), grant them. This patch is written to help users upgrading from older version better adapt to PR #7705.

@j2rong4cn
Copy link
Contributor

j2rong4cn commented Dec 29, 2024

internal/bootstrap/data/user.go#L67
这两个函数是不是可以移到patch模块?

@j2rong4cn
Copy link
Contributor

internal/bootstrap/data/user.go#L35
还有默认权限是不是少给了

@KirCute
Copy link
Contributor Author

KirCute commented Dec 29, 2024

internal/bootstrap/data/user.go#L35 还有默认权限是不是少给了

有人说webdav的密码可以暴力破解而不触发网页端那个登录尝试次数限制,admin权限比较大而且用户名好猜,容易成为被攻击的点,所以我想的是从下个版本开始不使用管理员用户登录webdav的用户就默认关掉admin的webdav权限,不关也行其实

@j2rong4cn
Copy link
Contributor

internal/bootstrap/data/user.go#L35 还有默认权限是不是少给了

有人说webdav的密码可以暴力破解而不触发网页端那个登录尝试次数限制,admin权限比较大而且用户名好猜,容易成为被攻击的点,所以我想的是从下个版本开始不使用管理员用户登录webdav的用户就默认关掉admin的webdav权限,不关也行其实

这样的话,单独创建一个用户来访问webdav确实安全一点,学到了

@xhofe xhofe merged commit 5994c17 into AlistGo:main Dec 30, 2024
3 checks passed
@KirCute KirCute deleted the feat/upgrade-patch branch December 30, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants