Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PWGUD] Fix global forward tracks selection and store tan lambda information #9185

Merged
merged 3 commits into from
Jan 5, 2025

Conversation

diana0x0f
Copy link
Contributor

The global forward tracks (MFT-MCH-MID type) were not selected properly for each BC, now this is done using the global BC info.
The tangent lambda information is stored in a new table to be able to perform the global muon refit as is done in DQ.

@diana0x0f diana0x0f changed the title Fix global forward tracks selection and store tan lambda information [PWGUD] Fix global forward tracks selection and store tan lambda information Jan 3, 2025
@alibuild
Copy link
Collaborator

alibuild commented Jan 3, 2025

Error while checking build/O2Physics/o2 for 1657ae4 at 2025-01-03 16:03:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/9185-slc9_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1620:15: error: unused variable 'nMIDs' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/9185-slc9_x86-64/0/PWGUD/TableProducer/UPCCandidateProducer.cxx:1616:56: error: comparison of integer expressions of different signedness: 'const long unsigned int' and 'const long int' [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

Copy link
Collaborator

@rolavick rolavick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you introduce this new table? Apparently, there is already a table with this parameter here

fwdtrack::X, fwdtrack::Y, fwdtrack::Z, fwdtrack::Phi, fwdtrack::Tgl,

Another approach how to obtain track.tgl is to use the px, py, px information from
DECLARE_SOA_TABLE(UDFwdTracks, "AOD", "UDFWDTRACK",
which are actually calculated based on tgl see here https://github.com/AliceO2Group/AliceO2/blob/64dd90cfb914805f3334aa32022581e7a05971b7/Framework/Core/include/Framework/AnalysisDataModel.h#L785

@diana0x0f
Copy link
Contributor Author

Hi @rolavick ,
we do not store the UDFwdTracksProp table, but sorry, I did not realise I could just use the px, py, pz information that is stored as a part of the UDFwdTracks table to calculate it. I will remove the new table.
Thanks for your help!

@github-actions github-actions bot removed the datamodel label Jan 5, 2025
@rolavick rolavick merged commit d6045c4 into AliceO2Group:master Jan 5, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants