Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SimCI] Revise tests #1517

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

benedikt-voelkel
Copy link
Contributor

  • standalone AnalysisQC test has been remobved in favor of developments in workflow test

  • generators

    • do not blindly test all INI files when run_generator_tests.sh changes
    • find files correctly when there are other changed files not related to generator testing
  • workflows revised logic such that

    • if MC/bin changes --> run anchored, --> check correct creation of workflows implemented by PWGs, --> test AnalysisQC and QC
    • if MC/analysis_testing or MC-related QC configurations change --> test AnalysisQC and QC, --> test O2DPG AnalysisQC CLI
    • if anchored-related shell scripts change --> run anchored

Copy link

github-actions bot commented Mar 1, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6

* standalone AnalysisQC test has been remobved in favor of developments
  in workflow test

* generators
  * do not blindly test all INI files when run_generator_tests.sh changes
  * find files correctly when there are other changed files not related
    to generator testing

* workflows
  revised logic such that
  * if MC/bin changes
    --> run anchored,
    --> check correct creation of workflows implemented by PWGs,
    --> test AnalysisQC and QC
  * if MC/analysis_testing or MC-related QC configurations change
    --> test AnalysisQC and QC,
    --> test O2DPG AnalysisQC CLI
  * if anchored-related shell scripts change
    --> run anchored

* relval
  * no changes
@benedikt-voelkel
Copy link
Contributor Author

Actions not properly run, probably due to https://www.githubstatus.com/incidents/wcl1sw4mzg60

@benedikt-voelkel
Copy link
Contributor Author

Once this is in, we can move forward with alisw/ali-bot#1296 @TimoWilken

@benedikt-voelkel
Copy link
Contributor Author

This will in fact not be tested, merging.

@benedikt-voelkel benedikt-voelkel merged commit cf41e32 into AliceO2Group:master Mar 1, 2024
4 checks passed
@benedikt-voelkel benedikt-voelkel deleted the test-sim branch March 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant