Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default for RECO_NUM_NODES_WORKFLOW_CMP #1505

Conversation

chiarazampolli
Copy link
Collaborator

@benedikt-voelkel , for https://its.cern.ch/jira/browse/O2-4706
@davidrohr , @martenole : 0 should be invalid as default, but I prefer that it crashes, than to put a meaningless value. Let me know.

Copy link

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2022-pp-apass4
async-2023-pbpb-apass
async-2023-pp-apass1
async-data
async-mc
async-2022-pp-apass6

@@ -29,6 +29,7 @@ fi
if [[ $SYNCMODE == 1 ]]; then NTRDTRKTHREADS=1; else NTRDTRKTHREADS=; fi

: ${NGPURECOTHREADS:=-1} # -1 = auto-detect
: ${RECO_NUM_NODES_WORKFLOW_CMP:=0} # 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would instead move the definition of RECO_NUM_NODES_WORKFLOW_CMP from line 161 up here.

@davidrohr
Copy link
Collaborator

Closing this in favor of #1506

@davidrohr davidrohr closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants