Add a check to prevent a -Wnull-dereference warning from GCC 12

AliceO2Group · Jan 26, 2023 · 7861fd2 · 7861fd2
1 parent dc989c6
commit 7861fd2
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/StfSender/StfSenderOutputUCX.cxx b/src/StfSender/StfSenderOutputUCX.cxx
@@ -235,7 +235,13 @@ bool StfSenderOutputUCX::disconnectTfBuilder(const std::string &pTfBuilderId)
       }
       return true;
     }
-    lConnInfo = std::move(mOutputMap.extract(lIt).mapped());
+    auto lConnInfoNode = mOutputMap.extract(lIt);
+    if (lConnInfoNode.empty()) {
+      // this should never happen, but the check makes the static analyzer happy
+      EDDLOG("StfSenderOutputUCX::disconnectTfBuilder: Internal error. tfb_id={}", pTfBuilderId);
+      return true;
+    }
+    lConnInfo = std::move(lConnInfoNode.mapped());
   }
 
   // Transport is only closed when other side execute close as well. Execute async