Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-532] Clean selection model #1835

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Separated selection model with precise options from selection model with remote data-based options

Changes made to the database:

  • N/A

- Separate selection model with precise options from selection model with remote data-based options
@martinboulais martinboulais self-assigned this Jan 15, 2025
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 2.45747% with 516 lines in your changes missing coverage. Please review.

Project coverage is 39.12%. Comparing base (86f5f39) to head (0bd328f).

Files with missing lines Patch % Lines
...ponents/Filters/RunsFilter/EorReasonFilterModel.js 0.00% 53 Missing ⚠️
...common/selection/FilterableRemoteSelectionModel.js 0.00% 49 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 28 Missing ⚠️
...s/common/filters/NumericalComparisonFilterModel.js 0.00% 28 Missing ⚠️
.../Filters/common/filters/ProcessedTextInputModel.js 0.00% 26 Missing ⚠️
...onents/Filters/RunsFilter/MagnetsFilteringModel.js 0.00% 24 Missing ⚠️
...blic/components/common/selection/SelectionModel.js 0.00% 24 Missing ⚠️
...nts/common/selection/dropdown/selectionDropdown.js 0.00% 24 Missing ⚠️
...c/components/Filters/RunsFilter/TimeRangeFilter.js 0.00% 17 Missing ⚠️
...blic/views/Runs/ActiveColumns/runsActiveColumns.js 0.00% 17 Missing ⚠️
... and 43 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1835      +/-   ##
==========================================
- Coverage   44.06%   39.12%   -4.95%     
==========================================
  Files         889      893       +4     
  Lines       15869    15858      -11     
  Branches     2993     2956      -37     
==========================================
- Hits         6993     6204     -789     
- Misses       8876     9654     +778     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant