Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-532] Improve runs overview run definition filter #1825

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Run definition filter is now using the factorized filtering system

Changes made to the database:

  • N/A

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 3.62319% with 266 lines in your changes missing coverage. Please review.

Project coverage is 43.88%. Comparing base (9758a3e) to head (5fe9f8a).

Files with missing lines Patch % Lines
...ponents/Filters/RunsFilter/EorReasonFilterModel.js 0.00% 53 Missing ⚠️
...nts/Filters/RunsFilter/RunDefinitionFilterModel.js 0.00% 30 Missing ⚠️
...public/components/Filters/common/FilteringModel.js 0.00% 28 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 21 Missing ⚠️
...onents/Filters/RunsFilter/MagnetsFilteringModel.js 0.00% 18 Missing ⚠️
...c/components/Filters/RunsFilter/TimeRangeFilter.js 0.00% 17 Missing ⚠️
.../public/components/runTypes/RunTypesFilterModel.js 0.00% 15 Missing ⚠️
...ponents/Filters/RunsFilter/DetectorsFilterModel.js 0.00% 14 Missing ⚠️
...nents/Filters/common/filters/RawTextFilterModel.js 0.00% 14 Missing ⚠️
.../components/runEorReasons/runEorReasonSelection.js 0.00% 12 Missing ⚠️
... and 12 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1825      +/-   ##
==========================================
- Coverage   43.88%   43.88%   -0.01%     
==========================================
  Files         889      890       +1     
  Lines       15863    15871       +8     
  Branches     2991     2977      -14     
==========================================
+ Hits         6962     6965       +3     
- Misses       8901     8906       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant