Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode URI components in buildURL function #1824

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Merge branch 'main' into mboulais/encode-uri-components-in-build-url

9a1df7d
Select commit
Loading
Failed to load commit list.
Open

Encode URI components in buildURL function #1824

Merge branch 'main' into mboulais/encode-uri-components-in-build-url
9a1df7d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 17, 2025 in 0s

44.00% (+0.00%) compared to 7a878e1

View this Pull Request on Codecov

44.00% (+0.00%) compared to 7a878e1

Details

Codecov Report

Attention: Patch coverage is 28.57143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 44.00%. Comparing base (7a878e1) to head (9a1df7d).

Files with missing lines Patch % Lines
lib/public/utilities/fetch/buildUrl.js 0.00% 4 Missing ⚠️
.../Environments/Overview/EnvironmentOverviewModel.js 0.00% 1 Missing ⚠️
lib/public/views/Flps/Flps.js 0.00% 1 Missing ⚠️
...ib/public/views/Logs/Overview/LogsOverviewModel.js 0.00% 1 Missing ⚠️
...ib/public/views/Runs/Overview/RunsOverviewModel.js 0.00% 1 Missing ⚠️
lib/public/views/Tags/Details/TagDetailsModel.js 0.00% 1 Missing ⚠️
...ib/public/views/Tags/Overview/TagsOverviewModel.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1824   +/-   ##
=======================================
  Coverage   44.00%   44.00%           
=======================================
  Files         891      891           
  Lines       15892    15893    +1     
  Branches     2997     2997           
=======================================
+ Hits         6993     6994    +1     
  Misses       8899     8899

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov