-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O2B-719] Add range based filtering for run number #1810
base: main
Are you sure you want to change the base?
[O2B-719] Add range based filtering for run number #1810
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1810 +/- ##
==========================================
- Coverage 44.07% 43.95% -0.12%
==========================================
Files 889 889
Lines 15862 15885 +23
Branches 2990 2997 +7
==========================================
- Hits 6991 6983 -8
- Misses 8871 8902 +31 ☔ View full report in Codecov by Sentry. |
The idea is good, but there is a major flaw: when using a very big range (with prod data) the app simply crash because the list of run numbers is too big. |
const rangeSize = end - start + 1; | ||
|
||
if (rangeSize > MAX_RANGE_SIZE) { | ||
return helpers.error('any.invalid', { message: `Range exceeds max size of 100 runs: ${runNumber}` }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use the constant also in the error message
I have a JIRA ticket
Notable changes for users:
-runNumber filter now accepts ranges as well
Notable changes for developers:
Changes made to the database: