Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1139] Refresh tags list when a tag is updated/created #1805

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

hattinf
Copy link
Collaborator

@hattinf hattinf commented Dec 2, 2024

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:
-tag colours will now update when looking at run details

Notable changes for developers:

Changes made to the database:

@hattinf hattinf added bug Something isn't working frontend labels Dec 2, 2024
@hattinf hattinf self-assigned this Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.48%. Comparing base (6f4cedf) to head (bec1e04).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
lib/public/views/Runs/Details/RunDetailsModel.js 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1805      +/-   ##
==========================================
- Coverage   43.78%   41.48%   -2.30%     
==========================================
  Files         893      889       -4     
  Lines       15954    15862      -92     
  Branches     3003     2990      -13     
==========================================
- Hits         6985     6581     -404     
- Misses       8969     9281     +312     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@martinboulais martinboulais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one test that covers the bug first (and expect it to fail), then implement the fix and see if the test pass

lib/public/views/Runs/Details/RunDetailsModel.js Outdated Show resolved Hide resolved
@hattinf hattinf requested a review from martinboulais December 4, 2024 15:44
test/public/runs/detail.test.js Outdated Show resolved Hide resolved
test/public/runs/detail.test.js Outdated Show resolved Hide resolved
test/public/runs/detail.test.js Outdated Show resolved Hide resolved
test/public/runs/detail.test.js Outdated Show resolved Hide resolved
test/public/runs/detail.test.js Outdated Show resolved Hide resolved
@hattinf hattinf requested a review from martinboulais December 9, 2024 12:48
};

let badges;
const expectedBgColorBefore = 'badge b1 b-gray-light bg-gray-light';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor point here: you expect class as initial state then the colors. It works, but the test would be more robust if you expect a given color at start and check the new color. To do so, could you have a look at updating the seeders accordingly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Development

Successfully merging this pull request may close these issues.

3 participants