-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[O2B-1139] Refresh tags list when a tag is updated/created #1805
base: main
Are you sure you want to change the base?
[O2B-1139] Refresh tags list when a tag is updated/created #1805
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1805 +/- ##
==========================================
- Coverage 43.78% 41.48% -2.30%
==========================================
Files 893 889 -4
Lines 15954 15862 -92
Branches 3003 2990 -13
==========================================
- Hits 6985 6581 -404
- Misses 8969 9281 +312 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add one test that covers the bug first (and expect it to fail), then implement the fix and see if the test pass
…/Refreshtagslistwhenatagisupdated/created
…/Refreshtagslistwhenatagisupdated/created
test/public/runs/detail.test.js
Outdated
}; | ||
|
||
let badges; | ||
const expectedBgColorBefore = 'badge b1 b-gray-light bg-gray-light'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor point here: you expect class as initial state then the colors. It works, but the test would be more robust if you expect a given color at start and check the new color. To do so, could you have a look at updating the seeders accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
I have a JIRA ticket
Notable changes for users:
-tag colours will now update when looking at run details
Notable changes for developers:
Changes made to the database: