Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O2B-1393] Use certificate when handling lost runs and envs #1793

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

martinboulais
Copy link
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Fixed error spamming server logs when trynig to handle lost runs and envs

Changes made to the database:

  • N/A

@martinboulais martinboulais added the bug Something isn't working label Nov 4, 2024
@martinboulais martinboulais self-assigned this Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 43.76%. Comparing base (6d2c9c9) to head (6c85733).

Files with missing lines Patch % Lines
lib/application.js 23.80% 16 Missing ⚠️
...ices/housekeeping/handleLostRunsAndEnvironments.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1793      +/-   ##
==========================================
+ Coverage   43.59%   43.76%   +0.17%     
==========================================
  Files         893      893              
  Lines       15950    15954       +4     
  Branches     3001     3005       +4     
==========================================
+ Hits         6953     6982      +29     
+ Misses       8997     8972      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinboulais
Copy link
Collaborator Author

Tested on openstack, request to ECS p2 works fine from here, but I was not able to test much further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

1 participant