Minor improvements

AliceO2Group · Dec 16, 2024 · ab2db87 · ab2db87
1 parent 6702603
commit ab2db87
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 4 deletions.
diff --git a/lib/public/components/Filters/common/FilterModel.js b/lib/public/components/Filters/common/FilterModel.js
@@ -65,4 +65,19 @@ export class FilterModel extends Observable {
     get visualChange$() {
         return this._visualChange$;
     }
+
+    /**
+     * Utility function to register a filter model as sub-filter model
+     *
+     * TODO for now this function simply propagate observable notifications, in the future this should register submodels with a key and allow
+     *      automated normalization (recursive filter model)
+     *
+     * @param {object} subModel the submodel to register
+     * @return {void}
+     * @protected
+     */
+    _addSubmodel(subModel) {
+        subModel.bubbleTo(this);
+        subModel?.visualChange$.bubbleTo(this._visualChange$);
+    }
 }
diff --git a/lib/public/components/Filters/common/TagFilterModel.js b/lib/public/components/Filters/common/TagFilterModel.js
@@ -27,11 +27,10 @@ export class TagFilterModel extends FilterModel {
     constructor(operators) {
         super();
         this._selectionModel = new TagSelectionDropdownModel({ includeArchived: true });
-        this._selectionModel.bubbleTo(this);
-        this._selectionModel.visualChange$.bubbleTo(this.visualChange$);
+        this._addSubmodel(this._selectionModel);
 
         this._combinationOperatorModel = new CombinationOperatorChoiceModel(operators);
-        this._combinationOperatorModel.bubbleTo(this);
+        this._addSubmodel(this._combinationOperatorModel);
     }
 
     // eslint-disable-next-line valid-jsdoc

diff --git a/lib/public/views/Runs/ActiveColumns/runsActiveColumns.js b/lib/public/views/Runs/ActiveColumns/runsActiveColumns.js
@@ -136,7 +136,8 @@ export const runsActiveColumns = {
         exportFormat: (tags) => tags?.length ? tags.map(({ text }) => text).join('-') : '-',
 
         /**
-         * Tag filter component
+         * Tags filter component
+         *
          * @param {RunsOverviewModel} runModel the runs overview model
          * @return {Component} the filter component
          */