fix part 2 of 2 to feedback implementation

AliceO2Group · Dec 11, 2024 · 32b6719 · 32b6719
1 parent 6fd47f0
commit 32b6719
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 10 deletions.
diff --git a/lib/public/views/Logs/Create/TemplatedLogCreationModel.js b/lib/public/views/Logs/Create/TemplatedLogCreationModel.js
@@ -50,9 +50,10 @@ export class TemplatedLogCreationModel extends LogCreationModel {
      *
      * @param {function} [onCreation] function called when log is created, with the id of the created log
      * @param {LogCreationRelations} relations the relations of the log
+     * @param {logTemplateKey|null} templateKey the key of the template to use
      * @param {object} templateData the template data of the log
      */
-    constructor(onCreation, relations, templateData) {
+    constructor(onCreation, relations, templateKey, templateData) {
         super(onCreation, relations);
 
         this._templateData = templateData;
@@ -63,14 +64,8 @@ export class TemplatedLogCreationModel extends LogCreationModel {
          */
         this._templateKey = null;
 
-        /**
-         * @type {LogTemplate|null}
-         * @private
-         */
-        this._template = null;
-
-        if (templateData.templateKey) {
-            this.useTemplate(templateData.templateKey);
+        if (templateKey) {
+            this.useTemplate(templateKey);
         }
     }
 

diff --git a/lib/public/views/Logs/LogsModel.js b/lib/public/views/Logs/LogsModel.js
@@ -139,7 +139,7 @@ export class LogsModel extends Observable {
             templateData.detectorOrSubsystem = detectorOrSubsystem;
         }
 
-        this._creationModel = new TemplatedLogCreationModel(this.handleLogCreation.bind(this), relations, templateData);
+        this._creationModel = new TemplatedLogCreationModel(this.handleLogCreation.bind(this), relations, templateKey, templateData);
         this._creationModel.bubbleTo(this);
     }