[O2B-844] Filter according to B field in runs (#1803)

* show * visible to false and removoe unnecessary profiles * add dipole and solenoid together test * remove redundant api test * add frontend test * update logs test to press runs element in navbar instead of using goToPage * fix linter issue * fix linter issue * fix linter issue * fix linter issue * fix linter issue * reverting back to goToPage * reverting back to goToPage * reverting back to goToPage * fix test result rows * test no check after reset an no more gotopage * fix test * remove unnecessary changes * comment in tests
AliceO2Group · Dec 11, 2024 · 0e891c6 · 0e891c6
1 parent f665ae4
commit 0e891c6
Show file tree

Hide file tree

Showing 3 changed files with 65 additions and 23 deletions.
diff --git a/lib/public/views/Runs/ActiveColumns/runsActiveColumns.js b/lib/public/views/Runs/ActiveColumns/runsActiveColumns.js
@@ -502,6 +502,6 @@ export const runsActiveColumns = {
         name: 'L3 / Dipole',
         visible: false,
         filter: ({ aliceL3AndDipoleCurrentFilter }) => selectionDropdown(aliceL3AndDipoleCurrentFilter, { selectorPrefix: 'l3-dipole-current' }),
-        profiles: ['runsPerLhcPeriod', 'runsPerDataPass', 'runsPerSimulationPass'],
+        profiles: ['runsPerLhcPeriod', 'runsPerDataPass', 'runsPerSimulationPass', profiles.none],
     },
 };
diff --git a/package-lock.json b/package-lock.json
diff --git a/test/public/runs/overview.test.js b/test/public/runs/overview.test.js
@@ -334,7 +334,7 @@ module.exports = () => {
     it('should successfully filter on tags', async () => {
         await waitForTableLength(page, 8);
 
-        // Open filter toggle
+        // Open filter toggle and wait for the dropdown to be visible
         await pressElement(page, '.tags-filter .dropdown-trigger');
         await pressElement(page, '#tag-dropdown-option-FOOD', true);
         await pressElement(page, '#tag-dropdown-option-RUN', true);
@@ -596,6 +596,17 @@ module.exports = () => {
         expect(runDurationList.every((runDuration) => runDuration === 'UNKNOWN')).to.be.true;
     });
 
+    it('should successfully apply alice currents filters', async () => {
+        await pressElement(page, '#reset-filters');
+
+        const popoverSelector = await getPopoverSelector(await page.waitForSelector('.aliceL3AndDipoleCurrent-filter .popover-trigger'));
+        await pressElement(page, `${popoverSelector} .dropdown-option:last-child`, true); // Select 30003kA/0kA
+
+        await expectColumnValues(page, 'runNumber', ['54', '53', '52']);
+
+        await pressElement(page, '#reset-filters');
+    });
+
     it('Should successfully filter runs by their run quality', async () => {
         await goToPage(page, 'run-overview');
         const filterInputSelectorPrefix = '#runQualityCheckbox';
@@ -1116,7 +1127,7 @@ module.exports = () => {
         await waitForNavigation(page, () => pressElement(page, 'a#home'));
         await waitForNavigation(page, () => pressElement(page, 'a#run-overview'));
 
-        // Not running run
+        // Not running run, wait for popover to be visible
         await pressElement(page, '#row104-runNumber-text .popover-trigger');
         let popoverSelector = await getPopoverSelector(await page.waitForSelector('#row104-runNumber-text .popover-trigger'));
         await page.waitForSelector(popoverSelector);