Fix

AliceO2Group · Dec 20, 2024 · 09aac6e · 09aac6e
1 parent 0de6e91
commit 09aac6e
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 8 deletions.
diff --git a/lib/public/utilities/fetch/buildUrl.js b/lib/public/utilities/fetch/buildUrl.js
@@ -112,23 +112,23 @@ export const buildUrl = (baseURL, parameters) => {
 
         if (Array.isArray(value)) {
             for (const subValue of value) {
-                formatAndPushQueryParameter(`${sanitize(key)}[]`, subValue);
+                formatAndPushQueryParameter(`${key}[]`, subValue);
             }
             return;
         }
 
         if (typeof value === 'object' && value !== null) {
             for (const [subKey, subValue] of Object.entries(value)) {
-                formatAndPushQueryParameter(`${sanitize(key)}[${sanitize(subKey)}]`, subValue);
+                formatAndPushQueryParameter(`${key}[${sanitize(subKey)}]`, subValue);
             }
             return;
         }
 
-        serializedQueryParameters.push(`${sanitize(key)}=${sanitize(value)}`);
+        serializedQueryParameters.push(`${key}=${sanitize(value)}`);
     };
 
     for (const [key, parameter] of Object.entries(parameters)) {
-        formatAndPushQueryParameter(key, parameter);
+        formatAndPushQueryParameter(sanitize(key), parameter);
     }
 
     return `${url}?${serializedQueryParameters.join('&')}`;

diff --git a/lib/utilities/buildUrl.js b/lib/utilities/buildUrl.js
@@ -112,23 +112,23 @@ exports.buildUrl = (baseURL, parameters) => {
 
         if (Array.isArray(value)) {
             for (const subValue of value) {
-                formatAndPushQueryParameter(`${sanitize(key)}[]`, subValue);
+                formatAndPushQueryParameter(`${key}[]`, subValue);
             }
             return;
         }
 
         if (typeof value === 'object' && value !== null) {
             for (const [subKey, subValue] of Object.entries(value)) {
-                formatAndPushQueryParameter(`${sanitize(key)}[${sanitize(subKey)}]`, subValue);
+                formatAndPushQueryParameter(`${key}[${sanitize(subKey)}]`, subValue);
             }
             return;
         }
 
-        serializedQueryParameters.push(`${sanitize(key)}=${sanitize(value)}`);
+        serializedQueryParameters.push(`${key}=${sanitize(value)}`);
     };
 
     for (const [key, parameter] of Object.entries(parameters)) {
-        formatAndPushQueryParameter(key, parameter);
+        formatAndPushQueryParameter(sanitize(key), parameter);
     }
 
     return `${url}?${serializedQueryParameters.join('&')}`;

diff --git a/test/lib/utilities/buildUrl.test.js b/test/lib/utilities/buildUrl.test.js
@@ -20,13 +20,15 @@ module.exports = () => {
             simple: 'hello',
             key: {
                 nested: [1, 2],
+                '=': 12,
             },
         }).split('?');
 
         const parametersExpressions = fullParametersExpressions.split('&');
         expect(parametersExpressions).to.includes('simple=hello');
         expect(parametersExpressions).to.includes('key[nested][]=1');
         expect(parametersExpressions).to.includes('key[nested][]=2');
+        expect(parametersExpressions).to.includes('key[%3D]=12');
     });
     it('should successfully build URL by combining existing parameters', () => {
         const [, fullParametersExpressions] = buildUrl('https://example.com?simple=hello&key1[key2][]=13&key1[key2][]=35', {