Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix in FT0 digitization (time wrt BC) #13833

Closed
wants to merge 1 commit into from
Closed

fix in FT0 digitization (time wrt BC) #13833

wants to merge 1 commit into from

Conversation

noferini
Copy link
Collaborator

@noferini noferini commented Jan 4, 2025

FT0 digitization: moving mIntRecord.getTimeOffsetWrtBC() when caching digit in order to use the current (and correct) collision time

Two plots from TOF QC after this commit is included... TOF-FT0 correlation recovered

immagine

immagine

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2025

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

afurs
afurs reviewed Jan 5, 2025
View reviewed changes
Detectors/FIT/FT0/simulation/src/Digitizer.cxx
@@ -220,7 +220,7 @@ void Digitizer::process(const std::vector<o2::ft0::HitType>* hits,
// Subtract time-of-flight from hit time
const Float_t timeOfFlight = hit.GetPos().R() / o2::constants::physics::LightSpeedCm2NS;
const Float_t timeOffset = is_A_side ? params.hitTimeOffsetA : params.hitTimeOffsetC;
Double_t hit_time = hit.GetTime() - timeOfFlight + timeOffset;
Double_t hit_time = hit.GetTime() - timeOfFlight + timeOffset + mIntRecord.getTimeOffsetWrtBC();

if (hit_time > 150) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also use hit_time here, w/o coll time

@afurs
Copy link
Collaborator

afurs commented Jan 5, 2025 •
edited
Loading

Hello @noferini I suggest to postpone this commit until we check some other cases (marked in the code) where hit_time is used w/o coll time.

@noferini
Copy link
Collaborator Author

noferini commented Jan 5, 2025

Hi @afurs ,
It Is fine.
Then I close the pr.
Cheers
Francesco

@noferini noferini closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afurs afurs afurs left review comments

@jotwinow jotwinow Awaiting requested review from jotwinow jotwinow is a code owner

@andreasmolander andreasmolander Awaiting requested review from andreasmolander andreasmolander is a code owner

@arvindkhuntia arvindkhuntia Awaiting requested review from arvindkhuntia arvindkhuntia is a code owner

@mslupeck mslupeck Awaiting requested review from mslupeck mslupeck is a code owner

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noferini @afurs