-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix in TOF sim digitization (decalibration), and add MC truth for QC … #13830
Conversation
REQUEST FOR PRODUCTION RELEASES:
This will add The following labels are available |
Adding as watcher |
Error while checking build/O2/fullCI for 2918a31 at 2025-01-01 18:44:
Full log here. |
9aa92bf
to
6f34b9c
Compare
Error while checking build/O2/fullCI for e78905d at 2025-01-06 16:09:
Full log here. |
This is an additional fix for TOF digitization.
After a deep debut I realized that de-calibration was done with the T.o.T. value before of the truncation to T.o.T. channel width.
This implied to slightly different T.o.T.-values used in de-calibration and calibration stages -> 50-60 ps shift and TOF sigma degradation.
After the fix simulations look consistent we expectations both in mean (0) and sigma (injected 60 ps).
Fix is related to the changes in Detectors/TOF/simulation/include/TOFSimulation/Digitizer.h (how tot is managed)
Additional changes are useful (they were when debugging) in order to trace MC truth for timing up to matching.
I did keep it since I would like to add some QC plots to constantly monitor deviation from expectation: both for TOF digitization and tracking (now I am able to disentangle the two effects in MC)
Once this is merged we will prepare also a PR for QC