Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix in TOF sim digitization (decalibration), and add MC truth for QC … #13830

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

noferini
Copy link
Collaborator

This is an additional fix for TOF digitization.
After a deep debut I realized that de-calibration was done with the T.o.T. value before of the truncation to T.o.T. channel width.
This implied to slightly different T.o.T.-values used in de-calibration and calibration stages -> 50-60 ps shift and TOF sigma degradation.
After the fix simulations look consistent we expectations both in mean (0) and sigma (injected 60 ps).

Fix is related to the changes in Detectors/TOF/simulation/include/TOFSimulation/Digitizer.h (how tot is managed)

Additional changes are useful (they were when debugging) in order to trace MC truth for timing up to matching.
I did keep it since I would like to add some QC plots to constantly monitor deviation from expectation: both for TOF digitization and tracking (now I am able to disentangle the two effects in MC)

Once this is merged we will prepare also a PR for QC

@noferini noferini requested a review from shahor02 as a code owner December 30, 2024 13:30
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@noferini
Copy link
Collaborator Author

Adding as watcher

@njacazio , @ercolessi

@alibuild
Copy link
Collaborator

alibuild commented Dec 31, 2024

Error while checking build/O2/fullCI for 2918a31 at 2025-01-01 18:44:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_NOGPU.log
reco_NOGPU.log:[33951:calib-phos-l1phase]: [17:43:54][ERROR] Exception while running: Fatal error. Rethrowing.
reco_NOGPU.log-[33951:calib-phos-l1phase]: [17:43:54][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-phos-calib-workflow, device shutting down. Reason: Fatal error
[33951:calib-phos-l1phase]: [17:43:53][ERROR] Requested resource does not exist: http://alice-ccdb.cern.ch//PHS/Calib/BadMap/1735753433992/
[33951:calib-phos-l1phase]: [17:43:53][FATAL] Got nullptr from CCDB for path PHS/Calib/BadMap and timestamp 1735753433992
[33951:calib-phos-l1phase]: [17:43:54][ERROR] Exception while running: Fatal error. Rethrowing.
[33951:calib-phos-l1phase]: [17:43:54][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-phos-calib-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 33951 (calib-phos-l1phase) did not exit correctly however it's not clear why. Exit code forced to 128.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/c520ef347f90c8d7d5f474337b1442809b55e6e5/slc8_x86-64/o2checkcode/1.0-local161/etc/modulefiles
++ cat
--

Full log here.

@sawenzel sawenzel merged commit 8b7ba4e into AliceO2Group:dev Jan 6, 2025
12 checks passed
@alibuild
Copy link
Collaborator

alibuild commented Jan 6, 2025

Error while checking build/O2/fullCI for e78905d at 2025-01-06 16:09:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:
Error in cling::AutoLoadingVisitor::InsertIntoAutoLoadingState:


## sw/BUILD/O2-full-system-test-latest/log
Detected critical problem in logfile reco_ASYNC.log
reco_ASYNC.log:[45225:internal-dpl-ccdb-backend]: [15:08:59][ERROR] Exception while running: Fatal error. Rethrowing.
reco_ASYNC.log-[45225:internal-dpl-ccdb-backend]: [15:08:59][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-ctf-reader-workflow, device shutting down. Reason: Fatal error
[45225:internal-dpl-ccdb-backend]: [15:08:58][ERROR] Failed to open file alien:///alice/data/CCDB/TPC/Config/AltroSyncSignal/07/52886/cd67fca8-aa89-11ef-8a14-200114580202?filetype=raw
[45225:internal-dpl-ccdb-backend]: [15:08:58][FATAL] Unable to find object TPC/Config/AltroSyncSignal/1550600800000
[45225:internal-dpl-ccdb-backend]: [15:08:59][ERROR] Exception while running: Fatal error. Rethrowing.
[45225:internal-dpl-ccdb-backend]: [15:08:59][FATAL] Unhandled o2::framework::runtime_error reached the top of main of o2-ctf-reader-workflow, device shutting down. Reason: Fatal error
[ERROR] Workflow crashed - PID 45225 (internal-dpl-ccdb-backend) did not exit correctly however it's not clear why. Exit code forced to 128.
[ERROR]  - Device internal-dpl-ccdb-backend: pid 45225 (exit 128)
[INFO]    - First error: [15:08:58][FATAL] Unable to find object TPC/Config/AltroSyncSignal/1550600800000
[ERROR] SEVERE: Device internal-dpl-ccdb-backend (45225) had at least one message above severity 5: Unable to find object TPC/Config/AltroSyncSignal/1550600800000


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/9a83c059fe69e4ca0109aa53fc1b783d7df4c288/slc8_x86-64/o2checkcode/1.0-local219/etc/modulefiles
++ cat
--

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants