Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL Analysis: add RNTuple arrow::Dataset support #13761

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

ktf
Copy link
Member

@ktf ktf commented Dec 2, 2024

As part of the changes, move the actual logic which serialises /
deserialised things to plugins so that we do not need to depend
or RNTuple in production code.

Include an initial converter to go from AO2Ds to RNTuple based files.

@ktf ktf requested a review from a team as a code owner December 2, 2024 14:57
Copy link
Contributor

github-actions bot commented Dec 2, 2024

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass4
async-2023-pp-apass4
async-2024-pp-apass1
async-2022-pp-apass7
async-2024-pp-cpass0
async-2024-PbPb-cpass0
async-2024-PbPb-apass1
async-2024-ppRef-apass1

@ktf
Copy link
Member Author

ktf commented Dec 4, 2024

Testing on hyperloop NOT ok. One leak fixed, one more leak to go.

@ktf ktf force-pushed the pr13761 branch 3 times, most recently from 0102838 to 8a0cef3 Compare December 12, 2024 12:44
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 8a0cef3 at 2024-12-12 13:48:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.

Full log here.

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 319d2cf at 2024-12-12 14:11:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13761-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:25:32: error: 'tracksQA_000' was not declared in this scope; did you mean 'tracksQA_002'?
/sw/SOURCES/O2Physics/13761-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:59:32: error: 'tracksQA_001' was not declared in this scope; did you mean 'tracksQA_002'?
ninja: build stopped: subcommand failed.

Full log here.

As part of the changes, move the actual logic which serialises /
deserialised things to plugins so that we do not need to depend
or RNTuple in production code.

Include an initial converter to go from AO2Ds to RNTuple based files.
@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 12597a2 at 2024-12-12 14:58:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13761-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:25:32: error: 'tracksQA_000' was not declared in this scope; did you mean 'tracksQA_002'?
/sw/SOURCES/O2Physics/13761-slc8_x86-64/0/Common/TableProducer/Converters/trackQA002Converter.cxx:59:32: error: 'tracksQA_001' was not declared in this scope; did you mean 'tracksQA_002'?
ninja: build stopped: subcommand failed.


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
++ GRERR=1
++ [[ 1 == 0 ]]
++ mkdir -p /sw/INSTALLROOT/0b8f077854784a4701c27532820db902e340be6a/slc8_x86-64/o2checkcode/1.0-local759/etc/modulefiles
++ cat
--

Full log here.

@ktf
Copy link
Member Author

ktf commented Dec 12, 2024

Orthogonal to everything else. Merging.

@ktf ktf merged commit 97e469e into AliceO2Group:dev Dec 12, 2024
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants