Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DPL: escape arguments with '&' character in CommandInfo #12873

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

knopers8
Copy link
Collaborator

The specific use are query parameters for apricot URIs in QC, which are delimited by &, such as:

o2-qc -b --config 'apricot://apricot-endpoint.cern.ch/components/qc/ANY/any/qc-config?process=true&aaa=333'

The specific use are query parameters for apricot URIs in QC, which are delimited by &, such as:
```
o2-qc -b --config 'apricot://apricot-endpoint.cern.ch/components/qc/ANY/any/qc-config?process=true&aaa=333'
```
@knopers8 knopers8 requested a review from a team as a code owner March 15, 2024 16:29
Copy link
Contributor

REQUEST FOR PRODUCTION RELEASES:
To request your PR to be included in production software, please add the corresponding labels called "async-" to your PR. Add the labels directly (if you have the permissions) or add a comment of the form (note that labels are separated by a ",")

+async-label <label1>, <label2>, !<label3> ...

This will add <label1> and <label2> and removes <label3>.

The following labels are available
async-2023-pbpb-apass
async-2023-pp-apass1
async-2022-pp-apass6
async-2022-pp-apass4
async-mc
async-data

@alibuild
Copy link
Collaborator

Error while checking build/O2/fullCI for 83cb2fe at 2024-03-15 18:56:

## sw/BUILD/O2-latest/log
c++: error: unrecognized command-line option '--rtlib=compiler-rt'
c++: error: unrecognized command-line option '--rtlib=compiler-rt'

Full log here.

@ktf
Copy link
Member

ktf commented Mar 18, 2024

Why splitting at the "&aaa=333"?

@knopers8
Copy link
Collaborator Author

I don't understand your question. The commit is to surround the argument containing & with single quotes, not to split it.

@ktf
Copy link
Member

ktf commented Mar 19, 2024

My dyslexic brain saw strtok rather than strpbrk.

@ktf ktf merged commit bf9324b into AliceO2Group:dev Mar 19, 2024
13 checks passed
@knopers8 knopers8 deleted the escape-ampersand branch March 19, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants