QC-479: merging supports vectors of TObject #12541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justonedev1
changed the title
justonedev1
changed the title
justonedev1
force-pushed
the
QC-479
branch
4 times, most recently
from
3a6149c to
6cc2484
Compare
added support for std::vector<TObject*> into linkDef.h std::vector<std::shared_ptr<TObject>> was added to the objectStorage Interactive and FullHistory mergers were updated to support vectors added vector example to mergersTopologyExample small refactoring
justonedev1
changed the title
knopers8
requested changes
Jan 26, 2024
knopers8
approved these changes
Jan 29, 2024
|
Thank you! |
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
* merging supports vectors of TObject; no tests * added vector support to extractObjectFrom function * deleter crash * merged vector is composed from shared_ptrs * tests for merging; working passing vector in example * vectors are supported in Mergers added support for std::vector<TObject*> into linkDef.h std::vector<std::shared_ptr<TObject>> was added to the objectStorage Interactive and FullHistory mergers were updated to support vectors added vector example to mergersTopologyExample small refactoring * fixup! vectors are supported in Mergers * fixup! fixup! vectors are supported in Mergers --------- Co-authored-by: Michal Tichák <[email protected]>
andreasmolander
pushed a commit
to andreasmolander/AliceO2
that referenced
this pull request
Apr 12, 2024
* merging supports vectors of TObject; no tests * added vector support to extractObjectFrom function * deleter crash * merged vector is composed from shared_ptrs * tests for merging; working passing vector in example * vectors are supported in Mergers added support for std::vector<TObject*> into linkDef.h std::vector<std::shared_ptr<TObject>> was added to the objectStorage Interactive and FullHistory mergers were updated to support vectors added vector example to mergersTopologyExample small refactoring * fixup! vectors are supported in Mergers * fixup! fixup! vectors are supported in Mergers --------- Co-authored-by: Michal Tichák <[email protected]>
mwinn2
pushed a commit
to mwinn2/AliceO2
that referenced
this pull request
Apr 25, 2024
* merging supports vectors of TObject; no tests * added vector support to extractObjectFrom function * deleter crash * merged vector is composed from shared_ptrs * tests for merging; working passing vector in example * vectors are supported in Mergers added support for std::vector<TObject*> into linkDef.h std::vector<std::shared_ptr<TObject>> was added to the objectStorage Interactive and FullHistory mergers were updated to support vectors added vector example to mergersTopologyExample small refactoring * fixup! vectors are supported in Mergers * fixup! fixup! vectors are supported in Mergers --------- Co-authored-by: Michal Tichák <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the first version of requested task, just to check whether I am doing correct thing before adding tests