-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
major refactor to enable consumers to use their own database + more #185
Draft
jpollard-cs
wants to merge
18
commits into
AlexzanderFlores:main
Choose a base branch
from
jpollard-cs:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpollard-cs
commented
Oct 23, 2021
•
edited
Loading
edited
- removes direct use of mongoose methods and abstracts data fetching/mutation with a repository interface which can be adapted for other consumers such as MySQL and postgres
- adds a domain layer to encapsulate business logic and provide a common persistence agnostic interface
- combines most guild settings data in a GuildSettingsAggregate object
- uses unary methods to make things easier to extend without having to change library internals, this is also superior to positional arguments as it allows easy addition of new arguments without breaking for the consumer (provided these can be optional)
- a few breaking changes (I will summarize when this is out of draft mode, but things that are most likely used internally and not by consumers)
- since we are caching data in the commands/wokcommands instances this has been turned into a proxy for data operations and mutations in these have become await-able and now handle persistence
- provides default mongo implementation for persistence
- cooldowns are broken out of the larger guild settings aggregate to keep things reasonably performant (caching strategy is also different here although it doesn't necessarily have to be - see notes in domain model code)
- dist folder removed from git
- still todo:
- finish wiring up repositories
- finish wiring up cooldowns
- generate typings automatically instead of needing to manually modify typings.d.ts file
- test all the things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.