Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add googleimage script #26

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

btrkeks
Copy link
Member

@btrkeks btrkeks commented Nov 5, 2024

Don't know if you want to add this, but I think using Google Image search is a bit nicer. Though you'll need API keys for this and store them in environment variables:

GOOGLE_API_KEY: https://developers.google.com/custom-search/v1/overview?hl=ja
SEARCH_ENGINE_ID: https://programmablesearchengine.google.com

100 searches per day are free.

image

@tatsumoto-ren
Copy link
Member

Since the project is in c++, it would make more sense to write the google script in c++ as well. Otherwise, it will greatly increase complexity of the installation steps and make the whole thing harder to maintain.

For now you could merge this into a different branch though. I believe you have admin rights here.

@btrkeks
Copy link
Member Author

btrkeks commented Nov 6, 2024

Yeah fair. Let's see, shouldn't take too long to rewrite a single http request and a for loop in C++

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants