monitor pg connection when uploading chunks #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathia-barahona
force-pushed
the
kathiabarahona/handle_connection_termination
branch
6 times, most recently
from
ad94dad to
7a1d76f
Compare
rdunklau
previously requested changes
Nov 20, 2024
kathia-barahona
force-pushed
the
kathiabarahona/handle_connection_termination
branch
2 times, most recently
from
fa6c42c to
2561768
Compare
rdunklau
reviewed
Nov 22, 2024
|
Other than the small comment on the status above, looks fine to me. |
kathia-barahona
force-pushed
the
kathiabarahona/handle_connection_termination
branch
from
2561768 to
d0cf535
Compare
rdunklau
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
While creating a backup, both
pg_start_backupandpg_stop_backupmust be executed within the same session. However, in some cases, the backup process may take several hours (especially when processing large chunks). During this time, the PostgreSQL instance may experience a restart, causing the connection used for the backup to be lost.As a result, pghoard may continue uploading chunks, only to encounter a connection error when attempting to finish the backup. This leads to wasted time, as the system attempts to complete the backup and then raises an exception due to the lost connection. The backup will then retry, potentially leading to further delays and redundant work.
So now, instead of letting the backup continue and fail due to a lost connection, each upload task will actively monitor the connection during the process. If the connection is lost, the task will be aborted, raising an exception to indicate that the connection is no longer available.
Resolves: #BF-2931
Why this way