schema_registry: standalone module for SR with basic dependency injection #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we create a new module schema_registry - we move all FastAPI related code into this new folder - going forward, move out all SR related things into this new folder
- leaving an example by killing the usage of ConfigDependencyManager
nosahama
commented
Nov 22, 2024
| import sys | ||
|
|
||
|
|
||
| def configure_logging(*, config: Config) -> None: |
There was a problem hiding this comment.
Even here, we can already use the DI, but let's move a bit and we build on this.
nosahama
commented
Nov 22, 2024
nosahama
force-pushed
the
nosahama/fastapi-sr-module-with-DI
branch
10 times, most recently
from
ca8ad2c to
37592da
Compare
we drop the dependency managers and use the DI containers and providers
nosahama
force-pushed
the
nosahama/fastapi-sr-module-with-DI
branch
from
37592da to
8224657
Compare
jjaakola-aiven
force-pushed
the
jjaakola-aiven-fastapi
branch
from
60a8086 to
7b8cd91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About this change - What it does
We move schema registry new FastAPI based implementation into it's own module
schema_registryand add dependency usage with an example of the application config injection, we can build up from here.