Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tracer: use noop exporter #1018

Conversation

nosahama
Copy link
Contributor

@nosahama nosahama commented Jan 7, 2025

About this change - What it does

  • we drop the span event usage
  • we add a no operation exporter

- we realised that this causes a lot of bloat in the console output and isn't actually used yet
@nosahama nosahama requested review from a team as code owners January 7, 2025 15:04
@nosahama nosahama force-pushed the nosahama/EC-228/otel-traces-use-noop-exporter branch from fb2f485 to 38db86c Compare January 7, 2025 15:24
Copy link

github-actions bot commented Jan 7, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  src/karapace
  config.py
  src/schema_registry
  reader.py
  src/schema_registry/telemetry
  tracer.py 41, 44
Project Total  

This report was generated by python-coverage-comment-action

@jjaakola-aiven jjaakola-aiven merged commit 7133718 into jjaakola-aiven-fastapi Jan 8, 2025
10 checks passed
@jjaakola-aiven jjaakola-aiven deleted the nosahama/EC-228/otel-traces-use-noop-exporter branch January 8, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants