fix CI failure of e2e tests #151
Conversation
Deploying dapp-psm with
|
| Latest commit: |
bde01c8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1d422753.dapp-psm.pages.dev |
| Branch Preview URL: | https://rs-fix-ci-failure-for-e2e-te.dapp-psm.pages.dev |
|
Cloudflare deployment logs are available here |
rabi-siddique
force-pushed
the
rs-fix-ci-failure-for-e2e-tests
branch
2 times, most recently
from
0577f17 to
f79324e
Compare
rabi-siddique
force-pushed
the
rs-fix-ci-failure-for-e2e-tests
branch
from
f79324e to
dca7c5a
Compare
Dockerfile
Outdated
| @@ -1,6 +1,9 @@ | |||
| # syntax=docker/dockerfile:1 | |||
| FROM --platform=linux/amd64 synthetixio/docker-e2e:18.16-ubuntu as base | |||
|
|
|||
| # Prefer IPv4 for DNS resolution | |||
There was a problem hiding this comment.
Sounds like some serious detective work! Consider explaining in the comment why to prefer IPv4.
| @@ -1,6 +1,9 @@ | |||
| # syntax=docker/dockerfile:1 | |||
| FROM --platform=linux/amd64 synthetixio/docker-e2e:18.16-ubuntu as base | |||
|
|
|||
| # Prefer IPv4 for DNS resolution | |||
| ENV NODE_OPTIONS=--dns-result-order=ipv4first | |||
There was a problem hiding this comment.
I wonder whether there's a way to disable ipv6 for the whole Docker daemon. Node doesn't seem like the right level of abstraction for compatibility with the GH Action runner
There was a problem hiding this comment.
Shall we try this solution if you recommend it?
Also, we can pass the host flag to vite. This will allow the development server to accept connections from all network interfaces, and we won't need to disable IPv6 or set a priority for IPv4.
There was a problem hiding this comment.
This isn't any worse than the other options :) The link will help if someone is running into complexity it creates
rabi-siddique
force-pushed
the
rs-fix-ci-failure-for-e2e-tests
branch
from
dca7c5a to
bde01c8
Compare
Recently, the end-to-end (e2e) tests for all dApps have been consistently failing. The underlying infrastructure of GitHub Actions can have different network configurations across different runs. Sometimes, the environment resolves localhost to
127.0.0.1 (IPv4), while other times it resolves to::1 (IPv6), leading to inconsistencies in the connection check. See this issue for details.The solution implemented in this PR sets the environment variable
NODE_OPTIONS=--dns-result-order=ipv4firstto prioritize IPv4 DNS resolution.