fix: sync with endo 1260 encodePassable #6260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erights
force-pushed
the
markm-sync-w-endo-1260
branch
3 times, most recently
from
cbec88d to
009ac64
Compare
erights
force-pushed
the
markm-sync-w-endo-1260
branch
3 times, most recently
from
6a16f58 to
69b5e1b
Compare
erights
force-pushed
the
markm-sync-w-endo-1260
branch
from
69b5e1b to
f192836
Compare
erights
force-pushed
the
markm-sync-w-endo-1260
branch
from
f192836 to
e55cf73
Compare
erights
force-pushed
the
markm-sync-w-endo-1260
branch
from
e55cf73 to
4cc5c60
Compare
|
Reviewers, |
erights
force-pushed
the
markm-sync-w-endo-1260
branch
2 times, most recently
from
5abf019 to
1c3f579
Compare
gibson042
approved these changes
Nov 10, 2022
erights
force-pushed
the
markm-sync-w-endo-1260
branch
from
1c3f579 to
4ac02dd
Compare
erights
force-pushed
the
markm-sync-w-endo-1260
branch
from
4ac02dd to
33b17a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endojs/endo#1260 started the migration of
encodePassable.jsandrankOrder.jsto the endo repository. Thus, it naturally contains a copy of these file that would work there. This is a maintenance hazard until the migration is complete and we can remove these files from agoric-sdk. In the meantime, development in each place can make changes that should also be made to the other. This is the agoric-sdk side of syncing the changes thus far.