allow .ts for package exports #10495
Draft
+429
−298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/utils.test.js:156:3 - error TS2775: Assertions require every name in the call target to be declared with an explicit type annotation.
156 assertAllDefined(foo);
~~~~~~~~~~~~~~~~
src/ses-utils.ts:141:14
141 export const assertAllDefined = <T extends Record<string, unknown>>(
~~~~~~~~~~~~~~~~
'assertAllDefined' needs an explicit type annotation.
Deploying agoric-sdk with
|
| Latest commit: |
2ba3884
|
| Status: | 🚫 Build failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #5760
Description
#10480 tries
.tsfor contracts, which are not part of a package's export surface.This spike explores using
.tsfiles for modules that are exported from a package. A complication is that while Typescript 5.7 can automatically convert rewrite.tsto.jsin its build output, we've so far avoided having a build stage during development. So we need a way to have.tslocally during development (without building) and for the packages in NPM to have only.jsfiles.Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations