Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set COVALENT_CONFIG_DIR to /tmp to allow filelock on slurm clusters #85

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

araghukas
Copy link
Contributor

Fixes: #84

Added

  • export COVALENT_CONFIG_DIR=/tmp inside sbatch script to enable filelock

Changed

  • Aesthetics and string formatting

  • I have added the tests to cover my changes.
  • I have updated the documentation, VERSION, and CHANGELOG accordingly.
  • I have read the CONTRIBUTING document.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (604a271) 93.11% compared to head (2be0f59) 93.16%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #85      +/-   ##
===========================================
+ Coverage    93.11%   93.16%   +0.04%     
===========================================
  Files            2        2              
  Lines          276      278       +2     
===========================================
+ Hits           257      259       +2     
  Misses          19       19              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@santoshkumarradha
Copy link
Member

this is a smart fix. Thanks @araghukas.

Since I don't have immediate access to SLURM, where you able to run the test workflow with this ?

@kessler-frost
Copy link
Member

Yes @santoshkumarradha , we tried running a basic workflow and were able to complete it successfully after this fix.

@kessler-frost kessler-frost merged commit f5085fb into develop Jan 4, 2024
18 checks passed
@kessler-frost kessler-frost deleted the 84-change-config-dir-to-tmp branch January 4, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not acquire file lock on Slurm cluster
3 participants