Use compile scope to transitively inherit acs-aem-commons-bundle #3317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This eases introducing Cloud-only API as the consumer should only depend on "acs-aem-commons-bundle-cloud" instead of "acs-aem-commons-bundle" (when running in AEMaaCS)
kwin
force-pushed
the
bugfix/scope-of-bundle-in-bundle-cloud
branch
from
08e55c4 to
919cc68
Compare
|
It is hard to exclude a dependency including its transitive dependencies in https://maven.apache.org/enforcer/enforcer-rules/bannedDependencies.html. Also I stumbled upon https://issues.apache.org/jira/browse/MENFORCER-502 which leads to different behaviour when building the module standalone (success) vs in the multimodule build (failure) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This eases introducing Cloud-only API as the consumer should only depend on "acs-aem-commons-bundle-cloud" instead of "acs-aem-commons-bundle" (when running in AEMaaCS)