-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #463 in HostlistsRegistry: remove internal IPs #1646
Conversation
It is related to #1224 and should be handled by HostlistCompiler |
@Alex-302 |
Better use regexps.
Note - in You can add test rules and run local build to check result. @AdamWr @piquark6046 Please also take a look, maybe regexps can be improved. |
https://regex101.com/r/qXOcCP/1 |
What is it?) Just invalid IP? |
If I'm not wrong, rule like this: ||10.32.17.182espn.hb.tt.omtrdc.net^ will be also excluded by this regex, or not? If so, maybe something like this:
can be used? |
|
@piquark6046 replaced. In general ok? |
#1646 (comment) |
@Sergey-Lyapin Please update PR according to #1646 (comment) |
@Alex-302 updated |
AdguardTeam/HostlistsRegistry#463