Zoisite - Sabs F & Yael P #58
Conversation
| raise Exception("Test needs to be completed.") | ||
| assert MOVIE_TITLE_1 == updated_data["watched"][0]["title"] | ||
| #my assert | ||
| assert MOVIE_TITLE_1 == updated_data["watched"][0]["title"] |
There was a problem hiding this comment.
You have two of the same assert statements here. Just be careful with that! Also, when we write equality asserts, it is typically best practice for the constants to be on the right had side of the assignment.
| # assert FANTASY_4 in friends_unique_movies | ||
| assert friends_unique_movies.count(INTRIGUE_3) == 1 | ||
| assert friends_unique_movies.count(HORROR_1) == 1 | ||
| assert friends_unique_movies.count(FANTASY_4) == 1 |
There was a problem hiding this comment.
Nice use of the count method in these asserts!
| # ****** Complete the Act and Assert Portions of these tests ********** | ||
| # ********************************************************************* | ||
| #the assert i wrote, lets hope this works | ||
| assert actual_output == [] |
| movie_dict = {'title': title, 'genre': genre, 'rating': rating} | ||
| return movie_dict | ||
| else: | ||
| return None |
There was a problem hiding this comment.
This looks great! The one small suggestion I'll make is that if a function doesn't explicitly return anything, it will return None by default. As a result, this else is actually unnecessary!
|
|
||
| def add_to_watchlist(user_data, movie): | ||
| user_data["watchlist"].append(movie) | ||
| return user_data |
| for friend in friend_list: | ||
| user_watched_list = user_data["watched"] | ||
| for movie in friend["watched"]: | ||
| subscription_list = user_data["subscriptions"] |
There was a problem hiding this comment.
Because this list is inside the loop, it's technically getting remade every single time. Best practice would have this list up with your other local variables!
| subscription_list = user_data["subscriptions"] | ||
| if movie["host"] in subscription_list and movie not in user_watched_list and movie not in recommendations: | ||
| recommendations.append(movie) | ||
| return recommendations |
There was a problem hiding this comment.
This function would be a great place to start leveraging your helper functions that you have created! For example, we have a way to isolate the movies that the user has not seen but at least one friend has (get_friends_unique_watched). Looping through that list will allow you to both cut down on the nested loops and cut down on the compound conditionals you've written!
| #will return popular genre | ||
|
|
||
| for movie in user_friend_watched: | ||
| if movie not in user_watched: |
There was a problem hiding this comment.
Remember that user_friend_watched specifically checks to make sure a movie hasn't been seen by the user! That renders this conditional unnecessary!
| if movie not in user_watched: | ||
| if movie["genre"] == user_most_watched_genre: | ||
| genre_recommended_movies.append(movie) | ||
| return (genre_recommended_movies) |
|
|
||
| return fav_recommended_movies |
There was a problem hiding this comment.
This will work, but remember we have helper functions we've created that will do a lot of this for us. Make sure you are using those to more appropriately approach this problem!
No description provided.