Task List Project #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgoslee
reviewed
Jun 23, 2021
Comment on lines
11
to
29
| def create_app(test_config=None): | ||
| app = Flask(__name__) | ||
| app.config["SQLALCHEMY_TRACK_MODIFICATIONS"] = False | ||
|
|
||
| if test_config is None: | ||
| app.config["SQLALCHEMY_DATABASE_URI"] = os.environ.get( | ||
| "SQLALCHEMY_DATABASE_URI") | ||
| else: | ||
| app.config["TESTING"] = True | ||
| app.config["SQLALCHEMY_DATABASE_URI"] = os.environ.get( | ||
| "SQLALCHEMY_TEST_DATABASE_URI") | ||
| app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False | ||
| app.config['SQLALCHEMY_DATABASE_URI'] = 'postgresql+psycopg2://postgres:postgres@localhost:5432/task_list_api_development' | ||
|
|
||
| db.init_app(app) | ||
| migrate.init_app(app, db) | ||
|
|
||
| # Import models here for Alembic setup | ||
| from app.models.task import Task | ||
| from app.models.goal import Goal | ||
|
|
||
| db.init_app(app) | ||
| migrate.init_app(app, db) | ||
| from .routes import task_list_api_bp | ||
| app.register_blueprint(task_list_api_bp) | ||
|
|
||
| # Register Blueprints here | ||
| from .routes import goals_bp | ||
| app.register_blueprint(goals_bp) | ||
|
|
||
| return app |
There was a problem hiding this comment.
this should go back to how you previously had it
if test_config is None: app.config["SQLALCHEMY_DATABASE_URI"] = os.environ.get( "SQLALCHEMY_DATABASE_URI") else: app.config["TESTING"] = True app.config["SQLALCHEMY_DATABASE_URI"] = os.environ.get( "SQLALCHEMY_TEST_DATABASE_URI")
tgoslee
reviewed
Jun 23, 2021
Comment on lines
+1
to
+20
| # from flask import Flask | ||
| # from flask_sqlalchemy import SQLAlchemy | ||
| # from flask_migrate import Migrate | ||
|
|
||
| # db = SQLAlchemy() | ||
| # migrate = Migrate() | ||
|
|
||
|
|
||
| # def create_app(test_config=None): | ||
| # app = Flask(__name__) | ||
|
|
||
| # app.config['SQLALCHEMY_TRACK_MODIFICATIONS'] = False | ||
| # app.config['SQLALCHEMY_DATABASE_URI'] = 'postgresql+psycopg2://postgres:postgres@localhost:5432/task_list_api_development' | ||
|
|
||
| # db.init_app(app) | ||
| # migrate.init_app(app, db) | ||
|
|
||
| # from app.models.task import Task | ||
|
|
||
| # return app |
tgoslee
reviewed
Jun 24, 2021
| task_id = db.Column(db.Integer, primary_key=True) | ||
| id = db.Column(db.Integer, primary_key=True, autoincrement=True) |
tgoslee
reviewed
Jun 24, 2021
| goal_id = db.Column(db.Integer, primary_key=True) | ||
| id = db.Column(db.Integer, primary_key=True) |
tgoslee
reviewed
Jun 24, 2021
|
|
||
|
|
||
| @task_list_api_bp.route("", methods=["GET", "POST"]) | ||
| def tasks(): |
There was a problem hiding this comment.
Because GET and POST are not using the same code you could consider created two different methods to handle GET and POST. For example, get_tasks and create_task
tgoslee
reviewed
Jun 24, 2021
| tasks = Task.query.all() | ||
|
|
||
| tasks_response = [] | ||
| # is_complete = task.completed_at |
tgoslee
reviewed
Jun 24, 2021
Comment on lines
+84
to
+89
| "task": { | ||
| "id": task.id, | ||
| "title": task.title, | ||
| "description": task.description, | ||
| "is_complete": task.completed_at | ||
| } |
There was a problem hiding this comment.
consider creating a helper function to add this. This makes your code more readable.
tgoslee
reviewed
Jun 24, 2021
|
|
||
|
|
||
| @goals_bp.route("", methods=["GET", "POST"]) | ||
| def handle_goals(): |
There was a problem hiding this comment.
Consider also breaking up this GET and POST for goals into two helper functions get_goals and create_goal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests were passing when I was submitting them but in the end, some of the first tests start to fail and I also didn't have enough time to deploy them before submitting the project.