-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Windows CI, but fixed #268
base: main
Are you sure you want to change the base?
Conversation
3479a55
to
8b48e63
Compare
c945afa
to
3fcb863
Compare
@paulo-ferraz-oliveira @elbrujohalcon could you take a look? CI fails with some stuff that's non-reproducible to me - it seems like it's improper stup/default, I'm not sure what to make of it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit-picking 🙈
@@ -0,0 +1,13 @@ | |||
-module(test_util). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In NextRoll, we usually call modules like this one test_utils
(plural).
Sorry about this… but… do you mind changing its name?
Now, for that CI pipeline… No idea what's going on, but from what - {you_cant, Open} when Open ->
+ throw:{you_cant, Open} when Open -> The original file doesn't have that It's very strange to me that this happens only in the Windows version. |
It might be the |
Also no idea what's the deal with |
I have to imagine that whatever vsn gets installed by gleam is wrong... the escript references "erl10.0" - is that right? |
No idea. @paulo-ferraz-oliveira do you know? |
Let me check (I think I've ran into this issue before). |
So, https://github.com/gleam-lang/setup-erlang/blob/main/main.ps1#L4 seems to convert 21.3 to 21. We might just have to open an issue next to |
Would it be acceptable to bump gleam's version to 22 for now? |
I'm pretty sure 22 has no pre-compiled Windows versions (on the Erlang Solutions repo.), which is why I chose 21.3, but you can always try again, here, and we can BE sure 🤣 (I looked around and couldn't find a reference to where I state 22 isn't available - since I trust past-me). |
@ElectronicRU, any news on this? I'd like to test an update to the Windows CI, but would prefer to do it on an already working version 😄 Thanks. |
@paulo-ferraz-oliveira Sorry, haven't been able to work on this - and honestly, I have a little clue as anyone at this point. :( |
Sure. I'll close my pull request, then, since this seems to be stalled. We can reopen later if required. |
Fixes bugs uncovered by #267.
List of changes: